Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Coordinator with a LoadBalancer service #167

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

burgerdev
Copy link
Contributor

No description provided.

@burgerdev burgerdev requested a review from 3u13r February 20, 2024 13:51
@katexochen
Copy link
Member

If this is the new recommended way, should we also update our justfile accordingly to use it?

@burgerdev
Copy link
Contributor Author

I was hesitant to do this because of additional cost (~10% of a CoCo node) in combination with the risk of accidentally leaking LBs in tests. Given that the current setup is working just fine, should we at least wait until we have the e2e framework?

@katexochen
Copy link
Member

I was hesitant to do this because of additional cost (~10% of a CoCo node) in combination with the risk of accidentally leaking LBs in tests. Given that the current setup is working just fine, should we at least wait until we have the e2e framework?

Fine for me.

Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgerdev burgerdev merged commit 6d25a1b into main Feb 22, 2024
5 checks passed
@burgerdev burgerdev deleted the burgerdev/reamde branch February 22, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants